Proxmark3 developers community

Research, development and trades concerning the powerful Proxmark3 device.

Remember; sharing is caring. Bring something back to the community.


"Learn the tools of the trade the hard way." +Fravia

You are not logged in.

#1 2013-10-17 16:31:44

ikarus
Contributor
Registered: 2012-09-20
Posts: 245
Website

htmldump.lua bugs

I hope this is the right place to put this.
I noticed some little bugs using

script run htmldump.lua

htmldump.png

Maybe someone with better lua skills than mine can fix these issues.
Thanks!
ikarus

P. S.: I love the new scripting stuff smile

Offline

#2 2013-10-17 16:45:48

asper
Contributor
Registered: 2008-08-24
Posts: 1,409

Re: htmldump.lua bugs

I have the same "color" issue but I cannot reproduce the "dash" bug, maybe it only happens with specific byte-values ?

To help holiman (which is a "lua-guru") please upload the problematic mifre dump somewhere in order for Holiman to download and test it; I think he will fix that really soon ! wink

PS I love the scripting stuff too !!

Last edited by asper (2013-10-17 16:46:06)

Offline

#3 2013-10-17 17:20:29

en4rab
Contributor
Registered: 2013-04-22
Posts: 36

Re: htmldump.lua bugs

in the file lualibs/htmlskel.lua
Line 67
            else if(byte < 11) el.className += " accessconditions";
change that to
            else if(byte < 10) el.className += " accessconditions";

that will fix the colouring for key B, as to the missing dashes, i cant reproduce that with the dump I have

Offline

#4 2013-10-17 17:31:15

ikarus
Contributor
Registered: 2012-09-20
Posts: 245
Website

Re: htmldump.lua bugs

asper wrote:

To help holiman (which is a "lua-guru") please upload the problematic mifre dump somewhere in order for Holiman to download and test it

Download: dumpdata.bin

Offline

#5 2013-10-17 18:16:39

en4rab
Contributor
Registered: 2013-04-22
Posts: 36

Re: htmldump.lua bugs

I have a fix for the empty cells not having a border too smile
In the same lualibs/htmlskel.lua file on line 30 it shows:

        td.sectorhdr{
            border-top: 1px solid white;
        }

change this to:

        td.sectorhdr{
            border-top: 1px solid white;
            empty-cells: show;
        }

And now any cells that hold just a space (0x20) will also have a border above them.

Offline

#6 2013-10-17 18:18:23

asper
Contributor
Registered: 2008-08-24
Posts: 1,409

Re: htmldump.lua bugs

Another lua-guru! Thank you en4rab!!

Offline

#7 2013-10-17 18:31:50

en4rab
Contributor
Registered: 2013-04-22
Posts: 36

Re: htmldump.lua bugs

I know nothing of LUA htmlskel.lua is actually a html/javascript template that the dump is inserted into, and i can just about do html and javascript.
like this which took me all day for 2 pages lol https://www.en4rab.co.uk/

Offline

#8 2013-10-17 19:25:16

holiman
Contributor
Registered: 2013-05-03
Posts: 566

Re: htmldump.lua bugs

Yeah, thanks!
As en4rab points out, this is vanilla js and html (vanilla == no jquery or other frameworks). I wanted it to be entirely self-contained and not needing any external components, thus jquery-less. However, I think there are a lot of fun things that can be done - examples include:
* Showing manufacturer-info.
* Access-bit calculator

If anyone wants to play around with it, I've put it on jsfiddle along with  en4rab's changes into a fiddle: http://jsfiddle.net/pebEG/
(I used td{emtpy-cells:show} , not just td.sectorhdr)

So, add anything you find missing, and post the new fiddle url here. When we're finished, I'll put it back into a self-contained page and commit. Oh, and I'll commit enr4abs changes right away.

Offline

Board footer

Powered by FluxBB